Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-nat #94

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Update go-nat #94

merged 1 commit into from
Aug 25, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Aug 24, 2016

resolves #93

@Kubuxu Kubuxu added the status/in-progress In progress label Aug 24, 2016
@whyrusleeping
Copy link
Contributor

@Kubuxu this updates go-nat, go-nat-pmp, jackpal/gateway and huin/goupnp ?

@whyrusleeping
Copy link
Contributor

(i forgot about gx diff silly me)

@Kubuxu
Copy link
Member Author

Kubuxu commented Aug 24, 2016

Yes, whole stack.

@whyrusleeping
Copy link
Contributor

Now i wish i had some gx changelog-diff so i can just view whats changed in each of these packages... But that would require gx to track git versions (which it doesnt do yet :( )

@whyrusleeping
Copy link
Contributor

Alright, this LGTM. I wish we had tests...

@Kubuxu
Copy link
Member Author

Kubuxu commented Aug 24, 2016

Yeah, I can create PR on go-ipfs so we test if it builds with the rest of the system.

@whyrusleeping
Copy link
Contributor

@Kubuxu that would be great!

@Kubuxu
Copy link
Member Author

Kubuxu commented Aug 25, 2016

I've run tests of go-ipfs, they were green: ipfs/kubo#3123

@whyrusleeping
Copy link
Contributor

odd... the OSX CI is failing, but the build log only shows successful tests...

@whyrusleeping whyrusleeping merged commit f5e4ebf into master Aug 25, 2016
@whyrusleeping whyrusleeping deleted the feat/go-nat-update branch August 25, 2016 19:20
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Aug 25, 2016
marten-seemann added a commit that referenced this pull request Apr 22, 2022
@marten-seemann
Merge pull request #94 from libp2p/simplify-dial-context
6e206c6 
simplify dial timeout context
marten-seemann pushed a commit that referenced this pull request Apr 26, 2022
@Stebalien
Merge pull request #94 from libp2p/chore/update
1ec5036 
chore: update deps
marten-seemann added a commit that referenced this pull request Apr 27, 2022
@marten-seemann
Merge pull request #94 from libp2p/check-peer-id-on-inbound
d7493ef 
add the peer ID to SecureInbound
marten-seemann pushed a commit that referenced this pull request Aug 17, 2022
@Stebalien
Merge pull request #94 from libp2p/feat/std-ed25519
bdeb1bf 
use standard library "crypto/ed25519"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update NAT library
2 participants
@Kubuxu @whyrusleeping